]> git.baikalelectronics.ru Git - kernel.git/commit
net: bnx2x: fix variable dereferenced before check
authorPavel Skripkin <paskripkin@gmail.com>
Sat, 13 Nov 2021 22:36:36 +0000 (01:36 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Nov 2021 13:28:49 +0000 (13:28 +0000)
commite7c17821465c049dd14c6218b1d818c666f6100c
tree30c03089c68719bf586e2cfa5b3f1ee0460f741c
parentcd7e4a6b87f1c45d8ab1d60f773adde93f565384
net: bnx2x: fix variable dereferenced before check

Smatch says:
bnx2x_init_ops.h:640 bnx2x_ilt_client_mem_op()
warn: variable dereferenced before check 'ilt' (see line 638)

Move ilt_cli variable initialization _after_ ilt validation, because
it's unsafe to deref the pointer before validation check.

Fixes: 8580edcf5068 ("bnx2x, cnic, bnx2i: use new FW/HSI")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_init_ops.h