]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: avoid declaring fs inconsistent due to invalid file handles
authorTheodore Ts'o <tytso@mit.edu>
Wed, 19 Dec 2018 17:29:13 +0000 (12:29 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 19 Dec 2018 17:29:13 +0000 (12:29 -0500)
commite7bd1e6cbc59a328f62be7f452c1518cf5b28801
tree4c2f7788f568c974552b1b1a158a0423dbe84f04
parent35a3e1ef45fc37eb2fef13a7ab978dba1fa939a7
ext4: avoid declaring fs inconsistent due to invalid file handles

If we receive a file handle, either from NFS or open_by_handle_at(2),
and it points at an inode which has not been initialized, and the file
system has metadata checksums enabled, we shouldn't try to get the
inode, discover the checksum is invalid, and then declare the file
system as being inconsistent.

This can be reproduced by creating a test file system via "mke2fs -t
ext4 -O metadata_csum /tmp/foo.img 8M", mounting it, cd'ing into that
directory, and then running the following program.

#define _GNU_SOURCE
#include <fcntl.h>

struct handle {
struct file_handle fh;
unsigned char fid[MAX_HANDLE_SZ];
};

int main(int argc, char **argv)
{
struct handle h = {{8, 1 }, { 12, }};

open_by_handle_at(AT_FDCWD, &h.fh, O_RDONLY);
return 0;
}

Google-Bug-Id: 120690101
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/ext4.h
fs/ext4/ialloc.c
fs/ext4/inode.c
fs/ext4/ioctl.c
fs/ext4/namei.c
fs/ext4/resize.c
fs/ext4/super.c
fs/ext4/xattr.c