]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: qla2xxx: Do not consume srb greedily
authorDaniel Wagner <dwagner@suse.de>
Tue, 29 Sep 2020 07:38:02 +0000 (09:38 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 8 Oct 2020 03:50:03 +0000 (23:50 -0400)
commite77636c4d07689fa032621e8b6d12e8e0ab9dfc5
tree2aeda6ae8e251d3cdd87711f598b5ddead8b9fd3
parentb00d6469bce8f84f8bb6c022e1faa2495cede16f
scsi: qla2xxx: Do not consume srb greedily

qla2xx_process_get_sp_from_handle() will clear the slot in which the
current srb is stored. As a result it can't be used in
qla24xx_process_mbx_iocb_response() to check for consistency and later
again in qla24xx_mbx_iocb_entry().

Move the consistency check directly into qla24xx_mbx_iocb_entry() and avoid
the double call or any open coding of the
qla2xx_process_get_sp_from_handle() functionality.

Link: https://lore.kernel.org/r/20200929073802.18770-1-dwagner@suse.de
Fixes: 197f292f9c7b ("scsi: qla2xxx: Handle incorrect entry_type entries")
Reviewed-by: Arun Easi <aeasi@marvell.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_isr.c