]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "cifs: Fix the target file was deleted when rename failed."
authorSteve French <stfrench@microsoft.com>
Thu, 23 Jul 2020 19:41:29 +0000 (14:41 -0500)
committerSteve French <stfrench@microsoft.com>
Thu, 23 Jul 2020 20:44:11 +0000 (15:44 -0500)
commite76b6b237dc2b1a1cbabae7134354c2604e1b6df
treef6dd5b0fcf44a1377618795084162ac96a4f25ad
parent21d0a5cf950768933cb88e716f8a3bf1031bcec4
Revert "cifs: Fix the target file was deleted when rename failed."

This reverts commit cd0d4035f9db18de8f9b17ffe2ef9cb566d8078f.

Upon additional testing with older servers, it was found that
the original commit introduced a regression when using the old SMB1
dialect and rsyncing over an existing file.

The patch will need to be respun to address this, likely including
a larger refactoring of the SMB1 and SMB3 rename code paths to make
it less confusing and also to address some additional rename error
cases that SMB3 may be able to workaround.

Signed-off-by: Steve French <stfrench@microsoft.com>
Reported-by: Patrick Fernie <patrick.fernie@gmail.com>
CC: Stable <stable@vger.kernel.org>
Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
Acked-by: Pavel Shilovsky <pshilov@microsoft.com>
Acked-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
fs/cifs/inode.c