]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "mm: compaction: handle incorrect MIGRATE_UNMOVABLE type pageblocks"
authorLinus Torvalds <torvalds@linux-foundation.org>
Mon, 4 Jun 2012 03:05:57 +0000 (20:05 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 4 Jun 2012 03:05:57 +0000 (20:05 -0700)
commite764700bb91ed278eacbdf4d0fc2d8f8dbc1766b
tree0a825d6f78e43d9ecc86429a99dcb40ed6628c25
parent25f781978333419b1c33ac6bc2f0b344897d8ceb
Revert "mm: compaction: handle incorrect MIGRATE_UNMOVABLE type pageblocks"

This reverts commit 7f820fd2c463d46d044028e359629df4e8b2df7f.

That commit seems to be the cause of the mm compation list corruption
issues that Dave Jones reported.  The locking (or rather, absense
there-of) is dubious, as is the use of the 'page' variable once it has
been found to be outside the pageblock range.

So revert it for now, we can re-visit this for 3.6.  If we even need to:
as Minchan Kim says, "The patch wasn't a bug fix and even test workload
was very theoretical".

Reported-and-tested-by: Dave Jones <davej@redhat.com>
Acked-by: Hugh Dickins <hughd@google.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/compaction.h
mm/compaction.c
mm/internal.h
mm/page_alloc.c