]> git.baikalelectronics.ru Git - kernel.git/commit
devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings
authorMike Looijmans <mike.looijmans@topic.nl>
Wed, 5 Oct 2016 14:03:08 +0000 (16:03 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Oct 2016 00:49:12 +0000 (20:49 -0400)
commite6b9bc6aff3b53c90a82f515752456927d92cdb4
treed0089102107d0070571f0e154357e7d8a43da07d
parentae7e308fb6a222ab0c12e2cb1ef5351a75e2ec8b
devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings

The KSZ9031 skew registers contain an offset, the chip's default value
is "neutral" which does not add any skew. Programming a 0 into a skew
property will actually set it the maximal negative adjustment and not
to a neutral position as one would expect.

Explain this situation in the devicetree binding documentation and list
the settings that the chip considers neutral.

Changing the implementation to accept negative values would have been
a better solution, but would break existing configurations.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Documentation/devicetree/bindings/net/micrel-ksz90x1.txt