]> git.baikalelectronics.ru Git - kernel.git/commit
drm/ingenic: Remove bogus register write
authorPaul Cercueil <paul@crapouillou.net>
Sat, 30 Oct 2021 10:00:32 +0000 (11:00 +0100)
committerPaul Cercueil <paul@crapouillou.net>
Sat, 30 Oct 2021 20:02:36 +0000 (21:02 +0100)
commite6b0d49551a5c524ca5f22035c2cac7d20887f34
tree9b558566c03fa964d54b13c6069db35c0aa316cc
parent4383a20fc62197d72176f6ef3558600fc8fc93c8
drm/ingenic: Remove bogus register write

Commit d781a121412b ("drm/ingenic: Simplify code by using hwdescs
array") caused the dma_hwdesc_phys_f{0,1} variables to be used while
uninitialized in a mmio register write, which most certainly broke the
ingenic-drm driver.

However, the very same patchset also submitted commit 2c65dadaafd7
("drm/ingenic: Upload palette before frame"), which restored a correct
behaviour by doing the register writes in a different place in the code.

What's left of this, is just to remove the bogus register writes in the
probe function.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211030100032.42066-1-paul@crapouillou.net
Acked-by: Sam Ravnborg <sam@ravnborg.org>
drivers/gpu/drm/ingenic/ingenic-drm-drv.c