]> git.baikalelectronics.ru Git - kernel.git/commit
regulator: vctrl-regulator: Avoid deadlock getting and setting the voltage
authorEnric Balletbo i Serra <enric.balletbo@collabora.com>
Thu, 16 Jan 2020 09:45:43 +0000 (10:45 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 17 Jan 2020 15:32:27 +0000 (15:32 +0000)
commite5f1648b23486ecc59dd1c4f9d19d1d06030c7a6
tree9e3e3aac08fb36828067dbc508d2e243906f5b4d
parent02b90f3227a3315e2d37a43a95cecffa32f663b2
regulator: vctrl-regulator: Avoid deadlock getting and setting the voltage

`cat /sys/kernel/debug/regulator/regulator_summary` ends on a deadlock
when you have a voltage controlled regulator (vctrl).

The problem is that the vctrl_get_voltage() and vctrl_set_voltage() calls the
regulator_get_voltage() and regulator_set_voltage() and that will try to lock
again the dependent regulators (the regulator supplying the control voltage).

Fix the issue by exporting the unlocked version of the regulator_get_voltage()
and regulator_set_voltage() API so drivers that need it, like the voltage
controlled regulator driver can use it.

Fixes: 206a0af25ab1 ("regulator: core: Use ww_mutex for regulators locking")
Reported-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20200116094543.2847321-1-enric.balletbo@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/core.c
drivers/regulator/vctrl-regulator.c