]> git.baikalelectronics.ru Git - kernel.git/commit
ibmvnic: send_login should check for crq errors
authorDany Madden <drt@linux.ibm.com>
Thu, 26 Nov 2020 00:04:30 +0000 (18:04 -0600)
committerJakub Kicinski <kuba@kernel.org>
Sat, 28 Nov 2020 21:26:48 +0000 (13:26 -0800)
commite5eda412cce929e5ab3ada0417ad2b2df0d88ad6
treecb916234ec8f918b7f1add0f87698668cfbe247b
parent28efa0c3c2cd5655fee6805cabc1fee8bcf0e12e
ibmvnic: send_login should check for crq errors

send_login() does not check for the result of ibmvnic_send_crq() of the
login request. This results in the driver needlessly retrying the login
10 times even when CRQ is no longer active. Check the return code and
give up in case of errors in sending the CRQ.

The only time we want to retry is if we get a PARITALSUCCESS response
from the partner.

Fixes: 70ece86a541c6 ("Driver for IBM System i/p VNIC protocol")
Signed-off-by: Dany Madden <drt@linux.ibm.com>
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/ibmvnic.c