]> git.baikalelectronics.ru Git - kernel.git/commit
selftest: tpm2: Add Client.__del__() to close /dev/tpm* handle
authorStefan Berger <stefanb@linux.ibm.com>
Tue, 20 Sep 2022 13:15:18 +0000 (09:15 -0400)
committerJarkko Sakkinen <jarkko@kernel.org>
Tue, 4 Oct 2022 21:25:56 +0000 (00:25 +0300)
commite5e520c57678a2254bd74a23fefec6adcfe17cbd
treebf3d7b96f7e427195bc911dab0e226dbf1773be4
parent104f412a6a0a97657662d1f81b999f48ac2dff7b
selftest: tpm2: Add Client.__del__() to close /dev/tpm* handle

The following output can bee seen when the test is executed:

  test_flush_context (tpm2_tests.SpaceTest) ... \
    /usr/lib64/python3.6/unittest/case.py:605: ResourceWarning: \
    unclosed file <_io.FileIO name='/dev/tpmrm0' mode='rb+' closefd=True>

An instance of Client does not implicitly close /dev/tpm* handle, once it
gets destroyed. Close the file handle in the class destructor
Client.__del__().

Fixes: 74a1753504515 ("selftests: add TPM 2.0 tests")
Cc: Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
tools/testing/selftests/tpm2/tpm2.py