]> git.baikalelectronics.ru Git - kernel.git/commit
qlcnic: potential dereference null pointer of rx_queue->page_ring
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Fri, 17 Dec 2021 09:39:11 +0000 (17:39 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 18 Dec 2021 12:37:12 +0000 (12:37 +0000)
commite5a8388b9a8aaf3c0d013df1e9ed1f77697ac1b3
treec7af9aac54119c897a11cae7ffd96820cb9584fd
parent67058ef2f6cefde5ae7e7f8c83bc11084c9795af
qlcnic: potential dereference null pointer of rx_queue->page_ring

The return value of kcalloc() needs to be checked.
To avoid dereference of null pointer in case of the failure of alloc.
Therefore, it might be better to change the return type of
qlcnic_sriov_alloc_vlans() and return -ENOMEM when alloc fails and
return 0 the others.
Also, qlcnic_sriov_set_guest_vlan_mode() and __qlcnic_pci_sriov_enable()
should deal with the return value of qlcnic_sriov_alloc_vlans().

Fixes: c64d69418c06 ("qlcnic: VLAN enhancement for 84XX adapters")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov.h
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c