]> git.baikalelectronics.ru Git - kernel.git/commit
ipv4: use the right lock for ping_group_range
authorWANG Cong <xiyou.wangcong@gmail.com>
Thu, 20 Oct 2016 21:19:46 +0000 (14:19 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 22 Oct 2016 20:23:12 +0000 (16:23 -0400)
commite547dcf6fe40d22e0e68c01f046ed36d4032d5f2
treee9421ffe250b8f5c509142bd79d313de39976457
parent41cfe1508a8d11a9ff9c89dbce0994d448ee8998
ipv4: use the right lock for ping_group_range

This reverts commit 6aac62d96dbdc23e610e66dc6913666d21673470
("ipv4: disable BH in set_ping_group_range()") because we never
read ping_group_range in BH context (unlike local_port_range).

Then, since we already have a lock for ping_group_range, those
using ip_local_ports.lock for ping_group_range are clearly typos.

We might consider to share a same lock for both ping_group_range
and local_port_range w.r.t. space saving, but that should be for
net-next.

Fixes: 6aac62d96dbd ("ipv4: disable BH in set_ping_group_range()")
Fixes: e99c5df57ea3 ("ping: move ping_group_range out of CONFIG_SYSCTL")
Cc: Eric Dumazet <edumazet@google.com>
Cc: Eric Salo <salo@google.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/sysctl_net_ipv4.c