]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "ALSA: sb8: add a check for request_region"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:57:01 +0000 (13:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:33:47 +0000 (17:33 +0200)
commite508c5360fb55c82dfbb44f2f6ac264f5242b09e
tree5ba0e61e296fe6ff729fa2fb6e8af94ac5ad9653
parent9a9bc51c893f9d1c681dd9bede59347768a4e7b2
Revert "ALSA: sb8: add a check for request_region"

This reverts commit 4333a39960b3ab0c769918e7a33c63e19e9d57cb.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original commit message for this change was incorrect as the code
path can never result in a NULL dereference, alluding to the fact that
whatever tool was used to "find this" is broken.  It's just an optional
resource reservation, so removing this check is fine.

Cc: Kangjie Lu <kjlu@umn.edu>
Acked-by: Takashi Iwai <tiwai@suse.de>
Fixes: 4333a39960b3 ("ALSA: sb8: add a check for request_region")
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-35-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/isa/sb/sb8.c