]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "i2c: core: Dispose OF IRQ mapping at client removal time"
authorJakub Kicinski <kubakici@wp.pl>
Wed, 11 Mar 2015 17:35:36 +0000 (18:35 +0100)
committerWolfram Sang <wsa@the-dreams.de>
Thu, 12 Mar 2015 09:23:05 +0000 (10:23 +0100)
commite4caac3eac331c3af3ec65bf7eaff571e0319e2a
treeaeed53bea51b29a3b501dd43badfe87242d22e58
parent048509a32a5445b6d6ea284dbb400133944c6213
Revert "i2c: core: Dispose OF IRQ mapping at client removal time"

This reverts commit b9c77a34f30a
("i2c: core: Dispose OF IRQ mapping at client removal time")

Calling irq_dispose_mapping() will destroy the mapping and disassociate
the IRQ from the IRQ chip to which it belongs. Keeping it is OK, because
existent mappings are reused properly.

Also, this commit breaks drivers using devm* for IRQ management on
OF-based systems because devm* cleanup happens in device code, after
bus's remove() method returns.

Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
Reported-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
[wsa: updated the commit message with findings fromt the other bug report]
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@kernel.org
Fixes: b9c77a34f30a
drivers/i2c/i2c-core.c