]> git.baikalelectronics.ru Git - kernel.git/commit
regulator: core: Fix enable_count imbalance with EXCLUSIVE_GET
authorZev Weiss <zev@bewilderbeest.net>
Thu, 5 May 2022 04:31:52 +0000 (21:31 -0700)
committerMark Brown <broonie@kernel.org>
Thu, 5 May 2022 14:13:06 +0000 (15:13 +0100)
commite4907a9f286193ea5dd7bfb9183940c0eaa7279b
treed4019b57c5076b6bd18fbcde5a2de09a1dd69ee3
parent8c90625228fef67f043c2750007dd40e4ddec57e
regulator: core: Fix enable_count imbalance with EXCLUSIVE_GET

Since the introduction of regulator->enable_count, a driver that did
an exclusive get on an already-enabled regulator would end up with
enable_count initialized to 0 but rdev->use_count initialized to 1.
With that starting point the regulator is effectively stuck enabled,
because if the driver attempted to disable it it would fail the
enable_count underflow check in _regulator_handle_consumer_disable().

The EXCLUSIVE_GET path in _regulator_get() now initializes
enable_count along with rdev->use_count so that the regulator can be
disabled without underflowing the former.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Fixes: 0a7ba1ffa5056 ("regulator: core: Only count load for enabled consumers")
Link: https://lore.kernel.org/r/20220505043152.12933-1-zev@bewilderbeest.net
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/core.c