]> git.baikalelectronics.ru Git - kernel.git/commit
net: mscc: ocelot: properly reject destination IP keys in VCAP IS1
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 4 Mar 2021 10:29:43 +0000 (12:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 4 Mar 2021 22:16:24 +0000 (14:16 -0800)
commite4760fdcb6f48d365bf9041134562c3eee70aa8b
treece16f56c37b3e544e3a8b8abaa553dc54c9c27b7
parent7fcd4c323fdf0a7f90729a0d6e4c772b5a18a782
net: mscc: ocelot: properly reject destination IP keys in VCAP IS1

An attempt is made to warn the user about the fact that VCAP IS1 cannot
offload keys matching on destination IP (at least given the current half
key format), but sadly that warning fails miserably in practice, due to
the fact that it operates on an uninitialized "match" variable. We must
first decode the keys from the flow rule.

Fixes: fd66c57872fc ("net: mscc: ocelot: offload ingress skbedit and vlan actions to VCAP IS1")
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mscc/ocelot_flower.c