]> git.baikalelectronics.ru Git - kernel.git/commit
mtd: rawnand: orion: Move the ECC initialization to ->attach_chip()
authorMiquel Raynal <miquel.raynal@bootlin.com>
Fri, 13 Nov 2020 12:34:17 +0000 (13:34 +0100)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 19 Nov 2020 20:52:32 +0000 (21:52 +0100)
commite42c021e71318393f322ba5c60ea75ea979d3bce
tree3fcd4ba45c01b1694bda7c0ec669f9b37bd681ca
parentbf9baf955eec1f0601696fe6ae6e6f49595003b1
mtd: rawnand: orion: Move the ECC initialization to ->attach_chip()

The probe function is only supposed to initialize the controller
hardware but not the ECC engine. Indeed, we don't know anything about
the NAND chip(s) at this stage. Let's move the logic initializing the
ECC engine, even pretty simple, to the ->attach_chip() hook which gets
called during nand_scan() routine, after the NAND chip discovery. As
the previously mentioned logic is supposed to parse the DT for us, it
is likely that the chip->ecc.* entries be overwritten. So let's avoid
this by moving these lines to ->attach_chip().

Fixes: 86503c2fe61f ("mtd: rawnand: Use the ECC framework user input parsing bits")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20201113123424.32233-13-miquel.raynal@bootlin.com
drivers/mtd/nand/raw/orion_nand.c