]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: cleanup bh release code in ext4_ind_remove_space()
authorzhangyi (F) <yi.zhang@huawei.com>
Sat, 23 Mar 2019 15:56:01 +0000 (11:56 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 23 Mar 2019 15:56:01 +0000 (11:56 -0400)
commite41b8d2eac5abd24fad136305036ec8cd44dce0d
tree36a3872930d45be5f5efd22a5862e14862d55ee6
parentdb272ead82ab2b44cd38fb07aa352f489fbdf22c
ext4: cleanup bh release code in ext4_ind_remove_space()

Currently, we are releasing the indirect buffer where we are done with
it in ext4_ind_remove_space(), so we can see the brelse() and
BUFFER_TRACE() everywhere.  It seems fragile and hard to read, and we
may probably forget to release the buffer some day.  This patch cleans
up the code by putting of the code which releases the buffers to the
end of the function.

Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
fs/ext4/indirect.c