]> git.baikalelectronics.ru Git - kernel.git/commit
lightnvm: fix uninitialized pointer in nvm_remove_tgt()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Fri, 21 Jun 2019 09:12:00 +0000 (11:12 +0200)
committerJens Axboe <axboe@kernel.dk>
Fri, 21 Jun 2019 09:14:30 +0000 (03:14 -0600)
commite3af1c1b4cdaceedd76ea1b0dad5e73b200cb7b1
tree6599a22dc9f902a9c39290bba7e2a8e536effbcc
parent2c8b88421b6a8345e39339df14ffdcb99aab5372
lightnvm: fix uninitialized pointer in nvm_remove_tgt()

With gcc 4.1:

    drivers/lightnvm/core.c: In function ‘nvm_remove_tgt’:
    drivers/lightnvm/core.c:510: warning: ‘t’ is used uninitialized in this function

Indeed, if no NVM devices have been registered, t will be an
uninitialized pointer, and may be dereferenced later.  A call to
nvm_remove_tgt() can be triggered from userspace by issuing the
NVM_DEV_REMOVE ioctl on the lightnvm control device.

Fix this by preinitializing t to NULL.

Fixes: 7a9acb2dc5ce09c9 ("lightnvm: do not remove instance under global lock")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/lightnvm/core.c