]> git.baikalelectronics.ru Git - kernel.git/commit
ipmi: work around gcc-4.9 build warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 6 Oct 2014 19:17:52 +0000 (14:17 -0500)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 7 Oct 2014 17:22:32 +0000 (13:22 -0400)
commite3a4c14f9155aa400d20f765c07002148f668e0f
tree915cc2e91a27973840659b82b9b8ad0a281eae26
parent87998a3c65d716e5bd4b59f4dd1d96e87284adcc
ipmi: work around gcc-4.9 build warning

Building ipmi on arm with gcc-4.9 results in this warning for an
allmodconfig build:

  drivers/char/ipmi/ipmi_si_intf.c: In function 'ipmi_thread':
  include/linux/time.h:28:5: warning: 'busy_until.tv_sec' may be used uninitialized in this function [-Wmaybe-uninitialized]
    if (lhs->tv_sec > rhs->tv_sec)
       ^
  drivers/char/ipmi/ipmi_si_intf.c:1007:18: note: 'busy_until.tv_sec' was declared here
    struct timespec busy_until;
                    ^

The warning is bogus and this case can not occur.  Apparently this is a
false positive resulting from gcc getting a little smarter about
tracking assignments but not smart enough.

Marking the ipmi_thread_busy_wait function as inline gives the gcc
optimization logic enough information to figure out for itself that the
case cannot happen, which gets rid of the warning without adding any
fake initialization.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/ipmi/ipmi_si_intf.c