]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: au88x0: Fix the missing snd_card_free() call at probe error
authorTakashi Iwai <tiwai@suse.de>
Tue, 12 Apr 2022 10:26:04 +0000 (12:26 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:34:05 +0000 (09:34 +0200)
commite3a0c625a9341811a92ce82490d851f59d207520
treecc96520898ae4eee19e2bb7154060bb32378bc4a
parent54a32672bc0df17e5fc1981e20e45c8d60675adc
ALSA: au88x0: Fix the missing snd_card_free() call at probe error

commit 39e66b4bdda32582521036d2f55ce9016851616f upstream.

The previous cleanup with devres may lead to the incorrect release
orders at the probe error handling due to the devres's nature.  Until
we register the card, snd_card_free() has to be called at first for
releasing the stuff properly when the driver tries to manage and
release the stuff via card->private_free().

This patch fixes it by calling snd_card_free() on the error from the
probe callback using a new helper function.

Fixes: 34bd1f869746 ("ALSA: au88x0: Allocate resources with device-managed APIs")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220412102636.16000-8-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/au88x0/au88x0.c