]> git.baikalelectronics.ru Git - kernel.git/commit
media: v4l2-ctrls: v4l2_ctrl_g/s_ctrl*(): don't continue when WARN_ON
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Tue, 3 Mar 2020 11:01:59 +0000 (12:01 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 21 Apr 2020 14:54:32 +0000 (16:54 +0200)
commite33a0477c5f13da77b10ccbe531c805afdc70727
tree9799b64374c29949a50153343f93d5e71a80b288
parent338e37aa58577227d234c84012eb4b38d0ee71c3
media: v4l2-ctrls: v4l2_ctrl_g/s_ctrl*(): don't continue when WARN_ON

If the v4l2_ctrl_g_ctrl*() or __v4l2_ctrl_s_ctrl*() functions
are called for the wrong control type then they call WARN_ON
since that is a driver error. But they still continue, potentially
overwriting data. Change this to return an error (s_ctrl) or 0
(g_ctrl), just to be safe.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/v4l2-core/v4l2-ctrls.c