]> git.baikalelectronics.ru Git - kernel.git/commit
tracing/osnoise: Properly unhook events if start_per_cpu_kthreads() fails
authorNikita Yushchenko <nikita.yushchenko@virtuozzo.com>
Sun, 9 Jan 2022 15:34:59 +0000 (18:34 +0300)
committerSteven Rostedt <rostedt@goodmis.org>
Thu, 13 Jan 2022 22:02:42 +0000 (17:02 -0500)
commite2e5836cf65c8ed93ef1128539c3e11bba1206ee
treeb682459630b9b95d2b6f00479114bea7913682ca
parent1e8c2a406d1fe5e28036a779e30c65a5a1f44bb7
tracing/osnoise: Properly unhook events if start_per_cpu_kthreads() fails

If start_per_cpu_kthreads() called from osnoise_workload_start() returns
error, event hooks are left in broken state: unhook_irq_events() called
but unhook_thread_events() and unhook_softirq_events() not called, and
trace_osnoise_callback_enabled flag not cleared.

On the next tracer enable, hooks get not installed due to
trace_osnoise_callback_enabled flag.

And on the further tracer disable an attempt to remove non-installed
hooks happened, hitting a WARN_ON_ONCE() in tracepoint_remove_func().

Fix the error path by adding the missing part of cleanup.
While at this, introduce osnoise_unhook_events() to avoid code
duplication between this error path and normal tracer disable.

Link: https://lkml.kernel.org/r/20220109153459.3701773-1-nikita.yushchenko@virtuozzo.com
Cc: stable@vger.kernel.org
Fixes: 02abf0541558 ("trace: Add osnoise tracer")
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Signed-off-by: Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_osnoise.c