]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: ipr: Eliminate duplicate barriers
authorArnd Bergmann <arnd@arndb.de>
Tue, 20 Mar 2018 02:50:05 +0000 (22:50 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 19 Jun 2018 01:02:52 +0000 (21:02 -0400)
commite273d24fa0c9171ff93b081cd9ec194d12c95908
treeea1db52ba3623f7243ece01e55a971e4e96602cf
parent8384cf31024e6cb34f24bc6e4ae2afd8388659a5
scsi: ipr: Eliminate duplicate barriers

Driver does both wmb() and writel(). The latter already has a barrier
on some architectures like arm64. This ends up with CPU observing two
barriers back to back before executing the register write.

Drivers should generally assume that the barrier implied by writel() is
sufficient for ordering DMA. Remove the extraneous wmb() before it.

[mkp: Squashed Arnd's and Sinan's patches]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reported-by: Sinan Kaya <okaya@codeaurora.org>
Acked-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ipr.c