]> git.baikalelectronics.ru Git - kernel.git/commit
x86/alternatives: Fix optimize_nops() checking
authorBorislav Petkov <bp@suse.de>
Wed, 10 Jan 2018 11:28:16 +0000 (12:28 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 10 Jan 2018 18:36:22 +0000 (19:36 +0100)
commite22c178596aba90bdcdf7ebb286f7aaae68669e0
tree8f5c3f1f6ae856deb97fae715cdb0c692a900d63
parent44baff0492fdd933a3b51106c82176fef49fe77f
x86/alternatives: Fix optimize_nops() checking

The alternatives code checks only the first byte whether it is a NOP, but
with NOPs in front of the payload and having actual instructions after it
breaks the "optimized' test.

Make sure to scan all bytes before deciding to optimize the NOPs in there.

Reported-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Andrew Lutomirski <luto@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linux-foundation.org>
Cc: Paul Turner <pjt@google.com>
Link: https://lkml.kernel.org/r/20180110112815.mgciyf5acwacphkq@pd.tnic
arch/x86/kernel/alternative.c