]> git.baikalelectronics.ru Git - kernel.git/commit
[media] DaVinci-VPBE: Check return value of a setup_if_config() call in vpbe_set_output()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 6 Nov 2016 19:40:20 +0000 (17:40 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 16 Nov 2016 17:24:37 +0000 (15:24 -0200)
commite1fa8be6348a723fbe1b76a445ce9645af3dc0e6
tree3135d4ed7b4b905d3d5c65267a1f45512894c9ea
parentcaa7bc5dd43d9d11fa054a4a9dfb5df3b11558b1
[media] DaVinci-VPBE: Check return value of a setup_if_config() call in vpbe_set_output()

* A function was called over the pointer "setup_if_config" in the data
  structure "venc_platform_data". But the return value was not used so far.
  Thus assign it to the local variable "ret" which will be checked with
  the next statement.

Fixes: 6ac442db671e6ed82481a670db43176e975c23b5 ("[media] davinci vpbe: add dm365 VPBE display driver changes")
* Pass a value to this function call without storing it in an intermediate
  variable before.

* Delete the local variable "if_params" which became unnecessary with
  this refactoring.

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/davinci/vpbe.c