]> git.baikalelectronics.ru Git - kernel.git/commit
media: allegro: Fix use after free on error
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 14 Dec 2020 11:54:47 +0000 (12:54 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 4 Jan 2021 12:18:00 +0000 (13:18 +0100)
commite1e054f611c1a0de19a56982228721e21c5a99ed
treed33f523f5473d597d9fa55d19689abec68e2a17c
parent9d301671121b384b633c10d86eb2505cc2345ca0
media: allegro: Fix use after free on error

The "channel" is added to the "dev->channels" but then if
v4l2_m2m_ctx_init() fails then we free "channel" but it's still on the
list so it could lead to a use after free.  Let's not add it to the
list until after v4l2_m2m_ctx_init() succeeds.

Fixes: 9ed461b89321 ("media: allegro: add missed checks in allegro_open()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/allegro-dvt/allegro-core.c