]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "ALSA: hda - Add mute-LED mode control to Thinkpad"
authorTakashi Iwai <tiwai@suse.de>
Sun, 24 May 2015 06:27:52 +0000 (08:27 +0200)
committerTakashi Iwai <tiwai@suse.de>
Sun, 24 May 2015 06:32:37 +0000 (08:32 +0200)
commite1d448ad0951eaca415a81e0884b7de6945b1033
treebc2435a4caa039078559a7ebc0153bcf22fe0eaf
parent2638c2a9fd68087b93beabf4ed3a6477adcb8b1a
Revert "ALSA: hda - Add mute-LED mode control to Thinkpad"

This reverts commit 9ebdc4b74fe25218691d636d379febf8ee7ff22f.

Through the regression report, it was revealed that the
tpacpi_led_set() call to thinkpad_acpi helper doesn't only toggle the
mute LED but actually mutes the sound.  This is contradiction to the
expectation, and rather confuses user.

According to Henrique, it's not trivial to judge which TP model
behaves "LED-only" and which model does whatever more intrusive, as
Lenovo's implementations vary model by model.  So, from the safety
reason, we should revert the patch for now.

Reported-by: Martin Steigerwald <martin@lichtvoll.de>
Cc: Pali Rohár <pali.rohar@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/thinkpad_helper.c