]> git.baikalelectronics.ru Git - kernel.git/commit
tty: n_gsm: fix DM command
authorDaniel Starke <daniel.starke@siemens.com>
Thu, 7 Jul 2022 11:32:21 +0000 (13:32 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:18:03 +0000 (11:18 +0200)
commite155a8e2de4ce83fa40a7caf62fbc2e8016fff32
tree9453c385e8964c6ae6dbcf8cca3d792a0a0e9a9e
parentbb3175eab620cdf89ba9eb568910892c5dfca419
tty: n_gsm: fix DM command

[ Upstream commit 2686f997e052ecc2aba8c07cbcc1645b2cd675d8 ]

n_gsm is based on the 3GPP 07.010 and its newer version is the 3GPP 27.010.
See https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1516
The changes from 07.010 to 27.010 are non-functional. Therefore, I refer to
the newer 27.010 here. Chapter 5.3.3 defines the DM response. There exists
no DM command. However, the current implementation incorrectly sends DM as
command in case of unexpected UIH frames in gsm_queue().
Correct this behavior by always sending DM as response.

Fixes: 99551fa31543 ("tty: n_gsm line discipline")
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
Link: https://lore.kernel.org/r/20220707113223.3685-2-daniel.starke@siemens.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/n_gsm.c