]> git.baikalelectronics.ru Git - kernel.git/commit
dmaengine: mediatek:Fix PM usage reference leak of mtk_uart_apdma_alloc_chan_resources
authorzhangqilong <zhangqilong3@huawei.com>
Sat, 19 Mar 2022 02:21:42 +0000 (10:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Apr 2022 12:38:52 +0000 (14:38 +0200)
commite111b7b48df5f69db5711f423318d8fb45b12a75
tree87470e92304f7c0bb2956637ba48b5295d5f0e12
parentecfc8c7ca44fad3b19cbac0aeb8a8ca813aeb0d0
dmaengine: mediatek:Fix PM usage reference leak of mtk_uart_apdma_alloc_chan_resources

[ Upstream commit eb0630bc6b9bae943fc0db5c5699d53274279732 ]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
We fix it:
1) Replacing it with pm_runtime_resume_and_get to keep usage counter
   balanced.
2) Add putting operation before returning error.

Fixes:dfa8527c83bc7 ("dmaengine: mediatek: Add MediaTek UART APDMA support")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20220319022142.142709-1-zhangqilong3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/mediatek/mtk-uart-apdma.c