]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: aardvark: Fix support for bus mastering and PCI_COMMAND on emulated bridge
authorPali Rohár <pali@kernel.org>
Thu, 28 Oct 2021 18:56:56 +0000 (20:56 +0200)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Fri, 29 Oct 2021 09:25:31 +0000 (10:25 +0100)
commite0d9fbd67bde7679bed59f5163e9f388a5289909
tree5be49ae799c1ff53a7f70fdc36c57a583de50738
parent9ed197510a46e03144347e7d69ea86e7cbf4262f
PCI: aardvark: Fix support for bus mastering and PCI_COMMAND on emulated bridge

From very vague, ambiguous and incomplete information from Marvell we
deduced that the 32-bit Aardvark register at address 0x4
(PCIE_CORE_CMD_STATUS_REG), which is not documented for Root Complex mode
in the Functional Specification (only for Endpoint mode), controls two
16-bit PCIe registers: Command Register and Status Registers of PCIe Root
Port.

This means that bit 2 controls bus mastering and forwarding of memory and
I/O requests in the upstream direction. According to PCI specifications
bits [0:2] of Command Register, this should be by default disabled on
reset. So explicitly disable these bits at early setup of the Aardvark
driver.

Remove code which unconditionally enables all 3 bits and let kernel code
(via pci_set_master() function) to handle bus mastering of Root PCIe
Bridge via emulated PCI_COMMAND on emulated bridge.

Link: https://lore.kernel.org/r/20211028185659.20329-5-kabel@kernel.org
Fixes: 3168fecd14ca ("PCI: aardvark: Implement emulated root PCI bridge config space")
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: stable@vger.kernel.org # 406454ab2f17 ("PCI: aardvark: Add FIXME comment for PCIE_CORE_CMD_STATUS_REG access")
drivers/pci/controller/pci-aardvark.c