]> git.baikalelectronics.ru Git - kernel.git/commit
iwlwifi: dvm: fix WoWLAN
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Sun, 20 Dec 2015 06:45:40 +0000 (08:45 +0200)
committerEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Thu, 7 Jan 2016 17:01:09 +0000 (19:01 +0200)
commite0afb99f70de4bad44a0e5be319a4d7927e5b8e8
treed1d80f978cfd5c40c69b0564baf9049c4dd71890
parent4675ef0a83b2934ff8b261a2fb5d2c75e4641f2d
iwlwifi: dvm: fix WoWLAN

My commit below introduced a mutex in the transport to
prevent concurrent operations. To do so, it added a flag
(is_down) to make sure the transport is in the right state.
This uncoverred an bug that didn't cause any harm until
now: iwldvm calls stop_device and then starts the firmware
without calling start_hw in between. While this flow is
fine from the device configuration point of view (register,
etc...), it is now forbidden by the new is_down flag.
This led to this error to appear:
iwlwifi 0000:05:00.0: Can't start_fw since the HW hasn't been started
and the suspend would fail.

This fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=109591

CC: <stable@vger.kernel.org> [4.3+]
Reported-by: Bogdan Bogush <bogdan.s.bogush@gmail.com>
Fixes=e225d0863ee1 ("iwlwifi: pcie: lock start_hw / start_fw / stop_device")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
drivers/net/wireless/intel/iwlwifi/dvm/lib.c