]> git.baikalelectronics.ru Git - kernel.git/commit
block: fix memleak of bio integrity data
authorJustin Tee <justin.tee@broadcom.com>
Thu, 5 Dec 2019 02:09:01 +0000 (10:09 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 5 Dec 2019 18:38:36 +0000 (11:38 -0700)
commite087d9af911d7a998dbb34fc2138ce97e78789cf
tree76f3d630387629bd6dcfa77163aa3aa94503cc07
parentf7405f727bd90dadcec458bdaccd0dcbc08d1bc4
block: fix memleak of bio integrity data

7bc834e76654 ("bio-integrity: stop abusing bi_end_io") moves
bio_integrity_free from bio_uninit() to bio_integrity_verify_fn()
and bio_endio(). This way looks wrong because bio may be freed
without calling bio_endio(), for example, blk_rq_unprep_clone() is
called from dm_mq_queue_rq() when the underlying queue of dm-mpath
is busy.

So memory leak of bio integrity data is caused by commit 7bc834e76654.

Fixes this issue by re-adding bio_integrity_free() to bio_uninit().

Fixes: 7bc834e76654 ("bio-integrity: stop abusing bi_end_io")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by Justin Tee <justin.tee@broadcom.com>

Add commit log, and simplify/fix the original patch wroten by Justin.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio-integrity.c
block/bio.c
block/blk.h