]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Fix TGL DKL PHY DP vswing handling
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 30 Sep 2020 22:36:42 +0000 (01:36 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 1 Oct 2020 12:14:16 +0000 (15:14 +0300)
commite07783d5e3f7e18cb4885b2d04731b3d4fe68d5e
treed7be893cf34b5b028bf6b57d7a986a654ad4a030
parent0c1c6966dda054fbfc84db1cef38b590e113156d
drm/i915: Fix TGL DKL PHY DP vswing handling

The HDMI vs. not-HDMI check got inverted whem the bogus encoder->type
checks were eliminated. So now we're using 0 as the link rate on DP
and potentially non-zero on HDMI, which is exactly the opposite of
what we want. The original bogus check actually worked more correctly
by accident since if would always evaluate to true. Due to this we
now always use the RBR/HBR1 vswing table and never ever the HBR2+
vswing table. That is probably not a good way to get a high quality
signal at HBR2+ rates. Fix the check so we pick the right table.

Cc: stable@vger.kernel.org
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Fixes: fd3745389559 ("drm/i915/display: Fix the encoder type check")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200930223642.28565-1-ville.syrjala@linux.intel.com
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
drivers/gpu/drm/i915/display/intel_ddi.c