]> git.baikalelectronics.ru Git - kernel.git/commit
be2net: Remove unnecessary frag list traversing.
authorDavid S. Miller <davem@davemloft.net>
Tue, 9 Jun 2009 08:01:31 +0000 (01:01 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Jun 2009 08:01:31 +0000 (01:01 -0700)
commite068c2d2cb3cb4cb51992a627ea904f36fb0f1a4
treeb8c26cff066e25e795d45b98d00047214bfa31de
parent5596c64e972a4b7baef615851e590626cfe463a7
be2net: Remove unnecessary frag list traversing.

This driver does not indicate support for frag lists.

Furthermore, even if it did, the code is walking the frag
lists incorrectly.  The idiom is:

for (iter = skb_shinfo(skb)->frag_list; iter; iter = iter->next)

but it's doing:

for (iter = skb_shinfo(skb)->frag_list; iter;
     iter = skb_shinfo(iter)->frag_list)

which would never work.  And this proves that this driver never
saw an SKB with active frag lists.

So just remove the code altogether and the driver TX path becomes
much simpler.

Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/benet/be_main.c