]> git.baikalelectronics.ru Git - kernel.git/commit
NFSv4: Fix state reference counting in _nfs4_opendata_reclaim_to_nfs4_state
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Mon, 28 Oct 2013 18:57:12 +0000 (14:57 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Mon, 28 Oct 2013 18:57:12 +0000 (14:57 -0400)
commite03fb2a78135eaf5670097b785af142ba8edfa79
tree7ec51c695820a1b15545cd99cf5827b54bf774eb
parent77a4a780e59c56ff9d5373f2b47a1a259bd0b83b
NFSv4: Fix state reference counting in _nfs4_opendata_reclaim_to_nfs4_state

Currently, if the call to nfs_refresh_inode fails, then we end up leaking
a reference count, due to the call to nfs4_get_open_state.
While we're at it, replace nfs4_get_open_state with a simple call to
atomic_inc(); there is no need to do a full lookup of the struct nfs_state
since it is passed as an argument in the struct nfs4_opendata, and
is already assigned to the variable 'state'.

Cc: stable@vger.kernel.org # 3.7.x: 77a4a780e59: NFSv4: don't fail on missing
Cc: stable@vger.kernel.org # 3.7.x
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/nfs4proc.c