]> git.baikalelectronics.ru Git - kernel.git/commit
serial: sh-sci: Don't check for mctrl_gpio_to_gpiod() returning error
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 14 Aug 2019 09:29:24 +0000 (11:29 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Sep 2019 10:43:54 +0000 (12:43 +0200)
commitdfebd6aa7def2820de4ee2ed17899e62a84e5d44
treee2ca7f57ca957a6b87cbd4b06c5b2c9f63a9e930
parent0c761b319a523a39c19582aa98133f7bb3b96652
serial: sh-sci: Don't check for mctrl_gpio_to_gpiod() returning error

Since commit 6de39c773b52b277 ("serial: mctrl-gpio: simplify init
routine"), mctrl_gpio_init() returns failure if the assignment to any
member of the gpio array results in an error pointer.
Since commit c359522194593815 ("serial: mctrl_gpio: Avoid probe failures
in case of missing gpiolib"), mctrl_gpio_to_gpiod() returns NULL in the
!CONFIG_GPIOLIB case.
Hence there is no longer a need to check for mctrl_gpio_to_gpiod()
returning an error value.  A simple NULL check is sufficient.

This follows the spirit of commit 8aba87e1320a50f5 ("serial: mctrl-gpio:
drop usages of IS_ERR_OR_NULL") in the mctrl-gpio core.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20190814092924.13857-4-geert+renesas@glider.be
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c