]> git.baikalelectronics.ru Git - kernel.git/commit
spi: bcm2835: bcm2835_spi_handle_err(): fix NULL pointer deref for non DMA transfers
authorMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 19 Jul 2022 07:22:35 +0000 (09:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 29 Jul 2022 15:25:24 +0000 (17:25 +0200)
commitdfd751bc43c190697b90afe9f6bee81b1d515fb9
tree9cef93e7d29098403da1357ad8808cb67b88af6a
parent2b568981fca9a79177f7890ecd217b9c86a290fd
spi: bcm2835: bcm2835_spi_handle_err(): fix NULL pointer deref for non DMA transfers

commit 4929a17f9b021b2fc736ba7d9fabc0ef1822fa80 upstream.

In case a IRQ based transfer times out the bcm2835_spi_handle_err()
function is called. Since commit d2ad94bb88af ("spi: bcm2835: Drop
dma_pending flag") the TX and RX DMA transfers are unconditionally
canceled, leading to NULL pointer derefs if ctlr->dma_tx or
ctlr->dma_rx are not set.

Fix the NULL pointer deref by checking that ctlr->dma_tx and
ctlr->dma_rx are valid pointers before accessing them.

Fixes: d2ad94bb88af ("spi: bcm2835: Drop dma_pending flag")
Cc: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://lore.kernel.org/r/20220719072234.2782764-1-mkl@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/spi/spi-bcm2835.c