]> git.baikalelectronics.ru Git - kernel.git/commit
net: lapbether: fix issue of dev reference count leakage in lapbeth_device_event()
authorZhengchao Shao <shaozhengchao@huawei.com>
Thu, 3 Nov 2022 09:05:37 +0000 (17:05 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Nov 2022 16:42:05 +0000 (17:42 +0100)
commitdfa6e95797488aada869d1d1c706c149a28f85ed
treee6e8258f875b786676873815fa4e087068d48a7b
parent4d53bc2cd243ca7e49be42919ca2199ecf4ae801
net: lapbether: fix issue of dev reference count leakage in lapbeth_device_event()

[ Upstream commit 0e409fdc255250cf3a2fd6c04a3f3b8633758554 ]

When following tests are performed, it will cause dev reference counting
leakage.
a)ip link add bond2 type bond mode balance-rr
b)ip link set bond2 up
c)ifenslave -f bond2 rose1
d)ip link del bond2

When new bond device is created, the default type of the bond device is
ether. And the bond device is up, lapbeth_device_event() receives the
message and creates a new lapbeth device. In this case, the reference
count value of dev is hold once. But after "ifenslave -f bond2 rose1"
command is executed, the type of the bond device is changed to rose. When
the bond device is unregistered, lapbeth_device_event() will not put the
dev reference count.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wan/lapbether.c