]> git.baikalelectronics.ru Git - kernel.git/commit
padata: fix uninitialized return value in padata_replace()
authorDaniel Jordan <daniel.m.jordan@oracle.com>
Mon, 10 Feb 2020 18:11:00 +0000 (13:11 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 22 Feb 2020 01:25:42 +0000 (09:25 +0800)
commitdf179e7ec5be8e280aaae1f69f884c404eb89e0b
tree65901dc6faf1b194cc337a76fa41ca434ce5a5f0
parent48d4de2594fd57431d4cb08bb4522876328db90d
padata: fix uninitialized return value in padata_replace()

According to Geert's report[0],

  kernel/padata.c: warning: 'err' may be used uninitialized in this
    function [-Wuninitialized]:  => 539:2

Warning is seen only with older compilers on certain archs.  The
runtime effect is potentially returning garbage down the stack when
padata's cpumasks are modified before any pcrypt requests have run.

Simplest fix is to initialize err to the success value.

[0] http://lkml.kernel.org/r/20200210135506.11536-1-geert@linux-m68k.org

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Fixes: c98e6b6451d2 ("crypto: pcrypt - Avoid deadlock by using per-instance padata queues")
Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
kernel/padata.c