]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: mv88e6xxx: Fix port_hidden_wait to account for port_base_addr
authorNathan Rossi <nathan@nathanrossi.com>
Mon, 25 Apr 2022 07:04:54 +0000 (07:04 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 May 2022 07:14:37 +0000 (09:14 +0200)
commitdef96856cce55a2a56d2c3f15a90c87ea2ab0add
tree74e0888574607aea54e9aaf6a8d5a23c2851fcd1
parenta4f0b9cf27ecefa3af42519c05d3280a72194113
net: dsa: mv88e6xxx: Fix port_hidden_wait to account for port_base_addr

[ Upstream commit 28a46aff21228c67dfcabd844669214a184731e5 ]

The other port_hidden functions rely on the port_read/port_write
functions to access the hidden control port. These functions apply the
offset for port_base_addr where applicable. Update port_hidden_wait to
use the port_wait_bit so that port_base_addr offsets are accounted for
when waiting for the busy bit to change.

Without the offset the port_hidden_wait function would timeout on
devices that have a non-zero port_base_addr (e.g. MV88E6141), however
devices that have a zero port_base_addr would operate correctly (e.g.
MV88E6390).

Fixes: ccdf6b67fe77 ("net: dsa: mv88e6xxx: update code operating on hidden registers")
Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Reviewed-by: Marek BehĂșn <kabel@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220425070454.348584-1-nathan@nathanrossi.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/dsa/mv88e6xxx/port_hidden.c