]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: nsp32: fix logic bug in error handling
authorArnd Bergmann <arnd@arndb.de>
Tue, 5 Sep 2017 07:51:29 +0000 (09:51 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 17 Oct 2017 02:38:44 +0000 (22:38 -0400)
commitdef1419c64ca3eae1d17870062cd38fe57aebd36
tree210ab08bd0937c6f31f4426aae59dc3891abe50d
parent8bf79900823ddce895919326e15aee0dcc1f2803
scsi: nsp32: fix logic bug in error handling

gcc-8 points out a logic error that has existed since the start of the
git history:

drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi':
drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
  if(((phase & BUSMON_BSY) == 1) || (phase & BUSMON_SEL) == 1) {
                           ^~

Presumably the author intended to check if one of two bits was set, so
that's what I'm changing the code to. This will obviously change the
behavior of the code, hopefully to do the right thing, but I have not
tested this or checked if the new "(phase & BUSMON_BSY) || (phase &
BUSMON_SEL)" condition should indeed be treated as a fatal error.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: GOTO Masanori <gotom@debian.or.jp>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/nsp32.c