]> git.baikalelectronics.ru Git - kernel.git/commit
platform/surface: fix potential integer overflow on shift of a int
authorColin Ian King <colin.king@canonical.com>
Mon, 11 Jan 2021 14:46:48 +0000 (14:46 +0000)
committerHans de Goede <hdegoede@redhat.com>
Wed, 13 Jan 2021 09:25:10 +0000 (10:25 +0100)
commitde619fa39cde4fb921212a9b512d8ffdd4db152c
tree8352fb176843fd6f5b3a6e23ab1aac7245c5ba10
parent2416fc554ee24103be3293f8f17edc6edbcf155a
platform/surface: fix potential integer overflow on shift of a int

The left shift of int 32 bit integer constant 1 is evaluated using 32 bit
arithmetic and then passed as a 64 bit function argument. In the case where
func is 32 or more this can lead to an oveflow.  Avoid this by shifting
using the BIT_ULL macro instead.

Addresses-Coverity: ("Unintentional integer overflow")
Fixes: 7b401a1c49d9 ("platform/surface: Add Surface ACPI Notify driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210111144648.20498-1-colin.king@canonical.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/surface/surface_acpi_notify.c