]> git.baikalelectronics.ru Git - kernel.git/commit
Input: palmas-pwrbutton - use IRQF_ONESHOT
authorNishanth Menon <nm@ti.com>
Mon, 15 Sep 2014 21:31:22 +0000 (14:31 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 15 Sep 2014 21:36:12 +0000 (14:36 -0700)
commitdd7d85314ae383f9d0a7edaca4bec8babec634ce
treef040c321346ba3a61089ba5797fb912c257cb08f
parent9e79233698668759bb2cd5a324ee53fd7c906c3a
Input: palmas-pwrbutton - use IRQF_ONESHOT

make C=2 CHECK="scripts/coccicheck" MODE=report COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci ./drivers/input/misc/palmas-pwrbutton.o
Reports:
drivers/input/misc/palmas-pwrbutton.c:213:9-29: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Palmas power button just needs threaded IRQ handler since I2C operations
are involved and there is nothing in non-threaded primary handler we could
do.

So mark the request with ONESHOT as it should have been done in these
cases.

Fixes: 41625879f6f1 ("Input: introduce palmas-pwrbutton")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/palmas-pwrbutton.c