]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: au88x0: use explicitly signed char
authorJason A. Donenfeld <Jason@zx2c4.com>
Mon, 24 Oct 2022 16:29:29 +0000 (18:29 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Nov 2022 14:56:53 +0000 (23:56 +0900)
commitdcfc9645af681db1b7f74dc8c2d2f9585a71abad
treead5da8db6a701c4469f1aa33400d62fc9efa1b8a
parentf0f829a14cd23ce3d89c43ccdae6e1f9fdcc5f47
ALSA: au88x0: use explicitly signed char

commit c07e4fe00f2dfa591572f5fa888fc3a85d6c10dd upstream.

With char becoming unsigned by default, and with `char` alone being
ambiguous and based on architecture, signed chars need to be marked
explicitly as such. This fixes warnings like:

sound/pci/au88x0/au88x0_core.c:2029 vortex_adb_checkinout() warn: signedness bug returning '(-22)'
sound/pci/au88x0/au88x0_core.c:2046 vortex_adb_checkinout() warn: signedness bug returning '(-12)'
sound/pci/au88x0/au88x0_core.c:2125 vortex_adb_allocroute() warn: 'vortex_adb_checkinout(vortex, (0), en, 0)' is unsigned
sound/pci/au88x0/au88x0_core.c:2170 vortex_adb_allocroute() warn: 'vortex_adb_checkinout(vortex, stream->resources, en, 4)' is unsigned

As well, since one function returns errnos, return an `int` rather than
a `signed char`.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20221024162929.536004-1-Jason@zx2c4.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/au88x0/au88x0.h
sound/pci/au88x0/au88x0_core.c