]> git.baikalelectronics.ru Git - kernel.git/commit
SUNRPC: Ensure we flush any closed sockets before xs_xprt_free()
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Sun, 3 Apr 2022 19:58:11 +0000 (15:58 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 May 2022 08:26:57 +0000 (10:26 +0200)
commitdc00c944e726c6818094560f0abe4e9926e7626f
treeadefe0cfb1136d5a90c3446efb87fb7ebb877bfd
parentc7c172fbde9fde102a6653df9441683cd403942e
SUNRPC: Ensure we flush any closed sockets before xs_xprt_free()

commit bc20328f6fd43f64472f61a54b134883ac91e231 upstream.

We must ensure that all sockets are closed before we call xprt_free()
and release the reference to the net namespace. The problem is that
calling fput() will defer closing the socket until delayed_fput() gets
called.
Let's fix the situation by allowing rpciod and the transport teardown
code (which runs on the system wq) to call __fput_sync(), and directly
close the socket.

Reported-by: Felix Fu <foyjog@gmail.com>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Fixes: 172771584d70 ("SUNRPC: Fix an Oops in udp_poll()")
Cc: stable@vger.kernel.org # 5.1.x: eaed0dc920f0: SUNRPC: Prevent immediate close+reconnect
Cc: stable@vger.kernel.org # 5.1.x: 7bb619385760: SUNRPC: Don't call connect() more than once on a TCP socket
Cc: stable@vger.kernel.org # 5.1.x
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: Meena Shanmugam <meenashanmugam@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/file_table.c
include/trace/events/sunrpc.h
net/sunrpc/xprt.c
net/sunrpc/xprtsock.c