]> git.baikalelectronics.ru Git - kernel.git/commit
net: pch_gbe: fix potential memleak in pch_gbe_tx_queue()
authorWang Hai <wanghai38@huawei.com>
Thu, 17 Nov 2022 06:55:27 +0000 (14:55 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Dec 2022 10:22:58 +0000 (11:22 +0100)
commitdbf2da84389a01cc1561003e047008bbcab30056
treedef8dab676b23a9ef4878c43a7f61c33cc21c7df
parent6627c530454cd2183ba5c19dbec65672eac71a99
net: pch_gbe: fix potential memleak in pch_gbe_tx_queue()

[ Upstream commit 2c3cf8c2d6f9bb0e5877d91283a08c2e304c34e1 ]

In pch_gbe_xmit_frame(), NETDEV_TX_OK will be returned whether
pch_gbe_tx_queue() sends data successfully or not, so pch_gbe_tx_queue()
needs to free skb before returning. But pch_gbe_tx_queue() returns without
freeing skb in case of dma_map_single() fails. Add dev_kfree_skb_any()
to fix it.

Fixes: d818c768e816 ("net: Add Gigabit Ethernet driver of Topcliff PCH")
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c