]> git.baikalelectronics.ru Git - kernel.git/commit
i40e: Fix for NUP NVM image downgrade failure
authorJacob Keller <jacob.e.keller@intel.com>
Fri, 27 Oct 2017 15:06:55 +0000 (11:06 -0400)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 22 Nov 2017 07:25:17 +0000 (23:25 -0800)
commitdb904e5ebe5f16e2fafc54eba6024ee486e2cbb0
tree488dcd5abb85384f2397dac9e4cd0cb9cd164ab3
parent6121690b0ee29125718569294db8d4084c133de2
i40e: Fix for NUP NVM image downgrade failure

Since commit b492cc855c94 ("i40e: Acquire NVM lock before
reads on all devices") we've used the NVM lock
to synchronize NVM reads even on devices which don't strictly
need the lock.

Doing so can cause a regression on older firmware prior to 1.5,
especially when downgrading the firmware.

Fix this by only grabbing the lock if we're running on an X722
device (which requires the lock as it uses the AdminQ to read
the NVM), or if we're currently running 1.5 or newer firmware.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_adminq.c
drivers/net/ethernet/intel/i40e/i40e_common.c
drivers/net/ethernet/intel/i40e/i40e_nvm.c
drivers/net/ethernet/intel/i40e/i40e_type.h