]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: amd: Replacing MSI with Legacy IRQ model
authorRavulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
Tue, 22 Dec 2020 11:59:18 +0000 (17:29 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 28 Dec 2020 14:22:27 +0000 (14:22 +0000)
commitdb3beb7b313bcd4540d318afe0c3ab96b6a76c66
treebcfc8f88758aa824db0e0977367578181e25edf4
parentca683ececbb0d58b7108a6c8ee7dafa91667ae4f
ASoC: amd: Replacing MSI with Legacy IRQ model

When we try to play and capture simultaneously we see that
interrupts are genrated but our handler is not being acknowledged,
After investigating further more in detail on this issue we found
that IRQ delivery via MSI from the ACP IP is unreliable and so sometimes
interrupt generated will not be acknowledged so MSI model shouldn't be used
and using legacy IRQs will resolve interrupt handling issue.

This patch replaces MSI interrupt handling with legacy IRQ model.

Issue can be reproduced easily by running below python script:

import subprocess
import time
import threading

def do2():
  cmd = 'aplay -f dat -D hw:2,1 /dev/zero -d 1'
    subprocess.call(cmd, stdin=subprocess.PIPE,
stderr=subprocess.PIPE, shell=True)
    print('Play Done')

def run():
for i in range(1000):
do2()

def do(i):
    cmd = 'arecord -f dat -D hw:2,2 /dev/null -d 1'
    subprocess.call(cmd, stdout=subprocess.PIPE,
stderr=subprocess.PIPE, shell=True)
    print(datetime.datetime.now(), i)

t = threading.Thread(target=run)
t.start()
for i in range(1000):
do(i)

t.join()

After applying this patch issue is resolved.

Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
Link: https://lore.kernel.org/r/20201222115929.11222-1-Vishnuvardhanrao.Ravulapati@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/raven/pci-acp3x.c