]> git.baikalelectronics.ru Git - kernel.git/commit
soc: sunxi: sram: Fix probe function ordering issues
authorSamuel Holland <samuel@sholland.org>
Mon, 15 Aug 2022 04:12:42 +0000 (23:12 -0500)
committerJernej Skrabec <jernej.skrabec@gmail.com>
Thu, 8 Sep 2022 20:28:03 +0000 (22:28 +0200)
commitdb0aa12442107fbe59c7224cd86e7604d4f1cc59
tree9cf96276a728248e3cdc250ee275794d47aa6a81
parent841edc766b58fb0ea76e2180b97936bdd1ed9d72
soc: sunxi: sram: Fix probe function ordering issues

Errors from debugfs are intended to be non-fatal, and should not prevent
the driver from probing.

Since debugfs file creation is treated as infallible, move it below the
parts of the probe function that can fail. This prevents an error
elsewhere in the probe function from causing the file to leak. Do the
same for the call to of_platform_populate().

Finally, checkpatch suggests an octal literal for the file permissions.

Fixes: 35c552b6fb96 ("drivers: soc: sunxi: Introduce SoC driver to map SRAMs")
Fixes: 9ec8c91d0de0 ("soc: sunxi: export a regmap for EMAC clock reg on A64")
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/20220815041248.53268-6-samuel@sholland.org
drivers/soc/sunxi/sunxi_sram.c